reviewing-changes
Performs comprehensive code reviews for Bitwarden iOS projects, verifying architecture compliance, style guidelines, compilation safety, test coverage, and security requirements. Use when reviewing pull requests, checking commits, analyzing code changes, verifying Bitwarden coding standards, evaluating unidirectional data flow pattern, checking services container dependency injection usage, reviewing security implementations, or assessing test coverage. Automatically invoked by CI pipeline or ma
Security Assessment
About reviewing-changes
The 'reviewing-changes' skill is designed to facilitate comprehensive code reviews for Bitwarden's iOS projects. It ensures that code changes are thoroughly evaluated for compliance with Bitwarden's high standards, covering architecture, style, compilation safety, test coverage, and security practices. This skill is particularly useful for reviewing pull requests, commits, and code changes, ensuring they align with the company's coding guidelines and security protocols. By automating certain checks, it helps developers maintain consistent, high-quality code in the Bitwarden ecosystem.
FAQ
How do I use the reviewing-changes skill?
This skill can be automatically triggered by a CI pipeline or manually invoked for interactive code reviews. To use it manually, initiate a code review and follow the process outlined in the documentation, starting with understanding the context and verifying compliance with Bitwarden's standards.
What coding standards does this skill check against?
The skill checks code against various standards documented in Bitwarden's guidelines, including architecture patterns, code style conventions, compilation safety, testing requirements, and security protocols. Specific documents referenced include CLAUDE.md, Docs/Architecture.md, and the Bitwarden Code Style guide.
What should I do if the reviewing-changes skill identifies a critical issue?
If a critical issue is flagged, it must be addressed before merging the code. The skill will provide actionable recommendations and specific file references to help resolve the issue. Critical issues may involve violations in architecture, security, or other core areas that could impact the functionality or security of the application.
Does this skill cover only new code changes?
No, the reviewing-changes skill also checks the surrounding code context, not just the new changes. It is important to review how the changes integrate with existing code to ensure overall system coherence.
What are some common mistakes to avoid when using this skill?
Some common mistakes include focusing only on new code without considering the surrounding context, nitpicking style issues that could be caught by linters, or requesting changes outside the scope of the changeset. It is also important to understand the context of the changes before reviewing.
Install reviewing-changes
Quick Setup:
- Copy the skill folder to
.claude/skills/ - Claude will automatically detect and use the skill
Repository
bitwarden/ios